feat: introduce scan.tag-name option to specify scanning from tag for reading given tag#85
Merged
lxy-9602 merged 1 commit intoalibaba:mainfrom Feb 5, 2026
Merged
Conversation
SteNicholas
force-pushed
the
PAIMON-83
branch
2 times, most recently
from
a32a8c2 to
62e7e31
Compare
There was a problem hiding this comment.
Pull request overview
Adds support for “time travel” reads from a named tag in batch mode by introducing a new scan.tag-name option and the supporting Tag/TagManager infrastructure.
Changes:
- Add
scan.tag-nameto options, CoreOptions, and scanning startup logic forFROM_SNAPSHOTmode. - Introduce
Tag(snapshot + tag metadata) andTagManagerfor loading tags from storage. - Add a new
StaticFromTagStartingScannerand update relevant tests/CMake wiring.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| test/inte/scan_inte_test.cpp | Updates expected error message when FROM_SNAPSHOT lacks required inputs. |
| src/paimon/core/utils/tag_manager_test.cpp | Adds tests for tag lookup/path generation. |
| src/paimon/core/utils/tag_manager.h | Introduces TagManager API for loading tags. |
| src/paimon/core/utils/tag_manager.cpp | Implements tag lookup and tag path construction. |
| src/paimon/core/utils/snapshot_manager.h | Exposes filesystem/root accessors used by tag-based scanning. |
| src/paimon/core/utils/snapshot_manager.cpp | Implements the new SnapshotManager accessors. |
| src/paimon/core/tag/tag_test.cpp | Adds serialization/deserialization and parsing tests for Tag. |
| src/paimon/core/tag/tag.h | Introduces Tag as an extension of Snapshot with tag fields. |
| src/paimon/core/tag/tag.cpp | Implements Tag JSON (de)serialization and trimming to Snapshot. |
| src/paimon/core/table/source/snapshot/static_from_tag_starting_scanner.h | Adds a starting scanner that reads from a specific tag. |
| src/paimon/core/table/source/abstract_table_scan.h | Wires scan.tag-name into FROM_SNAPSHOT startup logic. |
| src/paimon/core/core_options_test.cpp | Verifies default value for GetScanTagName(). |
| src/paimon/core/core_options.h | Adds CoreOptions::GetScanTagName(). |
| src/paimon/core/core_options.cpp | Parses/stores the new scan.tag-name option. |
| src/paimon/common/defs.cpp | Defines Options::SCAN_TAG_NAME. |
| src/paimon/CMakeLists.txt | Adds new source/test files to the build. |
| include/paimon/defs.h | Documents and declares Options::SCAN_TAG_NAME in the public header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/paimon/core/table/source/snapshot/static_from_tag_starting_scanner.h
Show resolved
Hide resolved
SteNicholas
force-pushed
the
PAIMON-83
branch
from
62e7e31 to
c978877
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/paimon/core/table/source/snapshot/static_from_tag_starting_scanner.h
Show resolved
Hide resolved
SteNicholas
force-pushed
the
PAIMON-83
branch
from
c978877 to
98a96d5
Compare
SteNicholas
force-pushed
the
PAIMON-83
branch
from
98a96d5 to
fc8ae95
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SteNicholas
force-pushed
the
PAIMON-83
branch
4 times, most recently
from
63c6005 to
89e18ca
Compare
Contributor
Author
|
Ping @lucasfang, @lxy-9602. |
lszskye
reviewed
Jan 28, 2026
lxy-9602
reviewed
Jan 28, 2026
lszskye
reviewed
Jan 28, 2026
SteNicholas
force-pushed
the
PAIMON-83
branch
from
22dba36 to
64033b3
Compare
SteNicholas
force-pushed
the
PAIMON-83
branch
from
64033b3 to
f390c5e
Compare
lszskye
reviewed
Jan 28, 2026
SteNicholas
force-pushed
the
PAIMON-83
branch
from
f390c5e to
346f039
Compare
SteNicholas
force-pushed
the
PAIMON-83
branch
16 times, most recently
from
1de3a86 to
c48e8f6
Compare
SteNicholas
force-pushed
the
PAIMON-83
branch
2 times, most recently
from
54637b6 to
3dbc9ef
Compare
… reading given tag
SteNicholas
force-pushed
the
PAIMON-83
branch
from
3dbc9ef to
f99bda1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #83
Introduce
scan.tag-name optionto specify scanning from tag for reading given tag.Tests
CoreOptionsTest, TestDefaultValueCoreOptionsTest TestFromMapScanInteTest, TestScanAppendWithInvalidOptionsTagManagerTest, TestGetTagManagerTest, TestTagPathTagTest, TestSimpleTagTest, TestFromPathTagTest, TestJsonizableTagTest, TestSerializeAndDeserializeScanInteTest, TestScanAppendWithTag1ScanInteTest, TestScanInvalidTagAPI and Format
Introduce
scan.tag-name optionoption to specify tag name used in case offrom-snapshotscan mode.Documentation
No.